./Clarity n'Code

Subscribe topic · by **libbyjix** » Mon Jun 26, 2017 8:39 am

Hi, there is a field in UBJsonReader.java named 'oldFormat' and it is defaulted to the value 'true'. When parsing a short data type, it executes this line:

Code: Select all: else if (type == 'I') return new JsonValue(oldFormat ? (long)din.readInt() : (long)din.readShort());

This causes the dataOutputStream to read 4 bytes instead of 2 which causes a mismatch between array length and the data being pulled from it and then throws the EOFException. So here's my question, should I use UBJsonWriter to write int arrays instead of short arrays* to accommodate for this old format and whatever technical reason(s) are behind it or is this a bug I should open an issue for? Here is the code that produces the problem:

Code: Select all: public class UBJsonReadWriteTest implements ApplicationListener { @Override public void create () { try{ UBJsonWriter writer = new UBJsonWriter( new FileOutputStream("test.bin") ); writer.object(); writer.set("shortArray", new short[]{((short)1), ((short)2), ((short)3)}); //writer.set("floatArray", new float[]{3,2,3}); <-- this run alone causes no error //writer.set("stringArray", new String[]{"dog", "hat", "run"}); <-- this run alone also causes no error writer.pop(); writer.close(); }catch(FileNotFoundException fnf){}catch(IOException ioe){} UBJsonReader reader = new UBJsonReader(); reader.parse(Gdx.files.getFileHandle("test.bin", Files.FileType.Internal)); } @Override public void render () {} @Override public void dispose () {} @Override public void resume(){} @Override public void pause(){} @Override public void resize(int x, int y){} }

and here is error output:

Exception in thread "LWJGL Application" com.badlogic.gdx.utils.SerializationException: Error parsing file: test.bin
at com.badlogic.gdx.utils.UBJsonReader.parse(UBJsonReader.java:56)
at com.mygdx.meshtest.UBJsonReadWriteTest.create(UBJsonReadWriteTest.java:46)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:149)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126)
Caused by: com.badlogic.gdx.utils.SerializationException:
at com.badlogic.gdx.utils.UBJsonReader.parse(UBJsonReader.java:45)
at com.badlogic.gdx.utils.UBJsonReader.parse(UBJsonReader.java:54)
... 3 more
Caused by: java.io.EOFException
at java.io.DataInputStream.readInt(DataInputStream.java:392)
at com.badlogic.gdx.utils.UBJsonReader.parse(UBJsonReader.java:86)
at com.badlogic.gdx.utils.UBJsonReader.parseArray(UBJsonReader.java:123)
at com.badlogic.gdx.utils.UBJsonReader.parse(UBJsonReader.java:70)
at com.badlogic.gdx.utils.UBJsonReader.parseObject(UBJsonReader.java:159)
at com.badlogic.gdx.utils.UBJsonReader.parse(UBJsonReader.java:72)
at com.badlogic.gdx.utils.UBJsonReader.parse(UBJsonReader.java:62)
at com.badlogic.gdx.utils.UBJsonReader.parse(UBJsonReader.java:43)
... 4 more

Thanks for any help.

*I checked the UBJsonWriter.java 'public UBJsonWriter value (short[] values) throws IOException{...}' function against the UBJson spec here: http://ubjson.org/type-reference/ and I don't see an error on that end which leads back to the 'oldFormat' UBJsonReader side of things.

./Clarity n'Code

| 4. Mon Jun 26, 2017 - UBJsonReader parse() a short[] throws EOFException

UBJsonReader parse() a short[] throws EOFException

UBJsonReader parse() a short[] throws EOFException

Re: UBJsonReader parse() a short[] throws EOFException

Re: UBJsonReader parse() a short[] throws EOFException

Re: UBJsonReader parse() a short[] throws EOFException

Re: UBJsonReader parse() a short[] throws EOFException

Re: UBJsonReader parse() a short[] throws EOFException

Who is online